Re: [PATCH] ksmbd: fix incorrect handling of iterate_dir

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>
> When I set the last entry of directory FAT chain to be invalid value in
> exFAT,
> the last getdents returns -EIO, but Samba sends responses without an error
There seems to be an attempt to improve this in Samba as well.
https://bugzilla.samba.org/show_bug.cgi?id=13718

>
>> >
>> >> There is no reason to follow it. I think that ksmbd is able to return
>> >> this error.
>> >
>> > Can we determine we should return a response with
>> > STATUS_FILE_CORRUPT_ERROR
>> > if iterate_dir returns -EIO?
>> STATUS_FILE_CORRUPT_ERROR is still not cleared. want to know how
>> windows server handle it.
>
> In the above example, Windows server sends an empty SMB2_QUERY_DIRECTORY
> response with STATUS_FILE_CORRUPT_ERROR.
>
> And when executing "dir <directory>" in Windows terminal for the local
> exFAT filesystem,
> there are no files iterated and DirIOError is generated.
This is the behavior I was expecting. ksmbd can handle this as well.

Thanks.
>
>
>> >
>> > --
>> > Thanks,
>> > Hyunchul
>> >
>
>
>
> --
> Thanks,
> Hyunchul
>



[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux