It does look like the first of these may fix a real leak setup_ntlmv2_rsp when called from CIFS_SessSetup doesn't seem to free ses->domainName sesInfoFree does free it but it is not clear whether in all paths sesInfoFree is called, but of course if it isn't called we have a much worse leak. Can you doublecheck about the memleak details. On Tue, Aug 23, 2022 at 12:45 PM Paulo Alcantara <pc@xxxxxx> wrote: > > Enzo Matsumiya <ematsumiya@xxxxxxx> writes: > > > > > Fix memory leaks from some ses fields when cifs_negotiate_protocol() or > > cifs_setup_session() fails in cifs_get_smb_ses(). > > > > A leak from ses->domainName has also been identified in setup_ntlmv2_rsp() > > when session setup fails. > > Those fields are already freed by sesInfoFree(). > > > These has been reported by kmemleak. > > Could you please include the report in commit message? -- Thanks, Steve
