Re: missing update to deferred_close_scheduled field

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This patch seems to cause an rmmod failure (after unmount) - will need
to test it more

On Fri, Aug 19, 2022 at 2:24 PM Steve French <smfrench@xxxxxxxxx> wrote:
>
> forgot to attach the correct version of the patch (had a cut-n-paste
> error on one line)
>
>
> On Fri, Aug 19, 2022 at 11:48 AM Steve French <smfrench@xxxxxxxxx> wrote:
> >
> > > we are missing a line like this:
> > >
> > >        cfile->deferred_close_scheduled = false;
> > >
> > > in cifs_open here:
> > >
> > >         /* Get the cached handle as SMB2 close is deferred */
> > >         rc = cifs_get_readable_path(tcon, full_path, &cfile);
> > >         if (rc == 0) {
> > >                 if (file->f_flags == cfile->f_flags) {
> > >                         file->private_data = cfile;
> > >                         spin_lock(&CIFS_I(inode)->deferred_lock);
> > >                         cifs_del_deferred_close(cfile);
> > >                         spin_unlock(&CIFS_I(inode)->deferred_lock);
> > >                         goto use_cache;
> >
> > So move set of deferred_close_scheduled = false into cifs_del_deferred_close
> >
> > See attached
> >
> > --
> > Thanks,
> >
> > Steve
>
>
>
> --
> Thanks,
>
> Steve



-- 
Thanks,

Steve



[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux