Re: [PATCH 5/9] cifs: Do not access tcon->cfids->cfid directly from is_path_accessible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



forgot to mention the obvious - the way to tell that this would be
helpful is simply looking at "/proc/fs/cifs/Stats" to see number of
opens vs. other operations.   Can also see pretty easily from simple
trace commands ("trace-cmd record -e smb3_open* smb3_close*") etc

On Thu, Aug 11, 2022 at 7:57 PM Steve French <smfrench@xxxxxxxxx> wrote:
>
> updated patch attached
>
>
> On Thu, Aug 11, 2022 at 7:56 PM Steve French <smfrench@xxxxxxxxx> wrote:
> >
> > Tentatively merged this patch (after rebasing it and fixing a minor
> > checkpatch problem).  Added Paulo's RB
> >
> > Skipped adding patch 4 though (cifs: Make tcon contain a wrapper
> > structure cached_fids instead of cached_fid) - let me know if problem
> > skipping that patch in the short term
> >
> > On Thu, Aug 11, 2022 at 8:20 AM Paulo Alcantara <pc@xxxxxx> wrote:
> > >
> > > Ronnie Sahlberg <lsahlber@xxxxxxxxxx> writes:
> > >
> > > > cfids will soon keep a list of cached fids so we should not access this
> > > > directly from outside of cached_dir.c
> > > >
> > > > Signed-off-by: Ronnie Sahlberg <lsahlber@xxxxxxxxxx>
> > > > ---
> > > >  fs/cifs/cached_dir.c | 10 ++++++----
> > > >  fs/cifs/cached_dir.h |  2 +-
> > > >  fs/cifs/readdir.c    |  4 ++--
> > > >  fs/cifs/smb2inode.c  |  2 +-
> > > >  fs/cifs/smb2ops.c    | 18 ++++++++++++++----
> > > >  5 files changed, 24 insertions(+), 12 deletions(-)
> > >
> > > Reviewed-by: Paulo Alcantara (SUSE) <pc@xxxxxx>
> >
> >
> >
> > --
> > Thanks,
> >
> > Steve
>
>
>
> --
> Thanks,
>
> Steve



-- 
Thanks,

Steve



[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux