[ resending this as the other one bounced ] On 07/27, Steve French wrote:
Of the first three patches, I think this one makes the most sense, but the rename should be "TCP_Server_Info" to something like "tcp_server_info" (or TCP_server_info) or something that indicates it is for the transport level info, info related to the network connection, the socket etc.
Noted.
(and not using the word "cifs" unless related to SMB1)
The "cifs" prefix is for the bigger picture (SMB1 isolation and/or module renaming) so I can later on do something like: "sed -i 's/cifs_/<newname>_/g' *.c"
---------- Forwarded message --------- From: Enzo Matsumiya <ematsumiya@xxxxxxx> Date: Mon, Jul 25, 2022 at 5:37 PM Subject: [RFC PATCH v2 03/10] cifs: rename "TCP_Server_Info" struct to "cifs_server_info" To: <linux-cifs@xxxxxxxxxxxxxxx> Cc: <smfrench@xxxxxxxxx>, <pc@xxxxxx>, <ronniesahlberg@xxxxxxxxx>, <nspmangalore@xxxxxxxxx> Rename the TCP_Server_Info struct to "cifs_server_info", making it look more like a cifs.ko struct by using the standard "cifs_" prefix. Also upgrades from Camel_Case to snake_case. Signed-off-by: Enzo Matsumiya <ematsumiya@xxxxxxx> --- fs/cifs/asn1.c | 4 +- fs/cifs/cifs_debug.c | 14 ++-- fs/cifs/cifs_debug.h | 4 +- fs/cifs/cifs_spnego.c | 2 +- fs/cifs/cifs_spnego.h | 2 +- fs/cifs/cifs_swn.h | 8 +-- fs/cifs/cifsencrypt.c | 14 ++-- fs/cifs/cifsfs.c | 6 +- fs/cifs/cifsglob.h | 140 ++++++++++++++++++++-------------------- fs/cifs/cifsproto.h | 114 ++++++++++++++++---------------- fs/cifs/cifssmb.c | 24 +++---- fs/cifs/connect.c | 134 +++++++++++++++++++------------------- fs/cifs/dfs_cache.c | 10 +-- fs/cifs/dir.c | 6 +- fs/cifs/file.c | 60 ++++++++--------- fs/cifs/fscache.c | 2 +- fs/cifs/inode.c | 22 +++---- fs/cifs/ioctl.c | 2 +- fs/cifs/link.c | 4 +- fs/cifs/misc.c | 10 +-- fs/cifs/netmisc.c | 2 +- fs/cifs/ntlmssp.h | 6 +- fs/cifs/readdir.c | 4 +- fs/cifs/sess.c | 52 +++++++-------- fs/cifs/smb1ops.c | 26 ++++---- fs/cifs/smb2inode.c | 2 +- fs/cifs/smb2misc.c | 14 ++-- fs/cifs/smb2ops.c | 86 ++++++++++++------------ fs/cifs/smb2pdu.c | 122 +++++++++++++++++----------------- fs/cifs/smb2proto.h | 58 ++++++++--------- fs/cifs/smb2transport.c | 44 ++++++------- fs/cifs/smbdirect.c | 10 +-- fs/cifs/smbdirect.h | 16 ++--- fs/cifs/transport.c | 48 +++++++------- 34 files changed, 536 insertions(+), 536 deletions(-)
