On 07/20, Steve French wrote:
Can you give some context as to why only smb2_find_dequeue_mid() set the "dequeue" flag to true and why it doesn't need to be distinguished from the other find_mid cases? I think Rohith wrote this - Rohith does the change make sense to you? Thoughts?
The way I see it, it's better to be explicit and do a find_mid() followed by a dequeue_mid(), than to have a function that do both, especially when that function is used only in one place (smb2_decrypt_offload()). Tho @Rohith please clarify if I missed something here.
Also Enzo can you explain a little what the callers were who set "malformed" (and why it now no longer needs to be used)?
This is, again, to be explicit. It makes no sense to me to have a "malformed" parameter in a function named "dequeue_mid", e.g. when reading the code I stumbled upon: dequeue_mid(mid, false); and dequeue_mid(mid, rdata->result); Let me know if this doesn't make sense to you. Cheers, Enzo
