On Fri, Jun 24, 2022 at 8:14 PM Steve French <smfrench@xxxxxxxxx> wrote: > > FYI - the last one includes the fix for the lock ordering problem that > Coverity spotted. > > On Fri, Jun 24, 2022 at 9:43 AM Shyam Prasad N <nspmangalore@xxxxxxxxx> wrote: > > > > On Mon, Jun 6, 2022 at 3:57 PM Shyam Prasad N <nspmangalore@xxxxxxxxx> wrote: > > > > > > On Mon, Jun 6, 2022 at 11:12 AM Shyam Prasad N <nspmangalore@xxxxxxxxx> wrote: > > > > > > > > Hi Paulo, > > > > > > > > Sorry for the late reply. > > > > Good point. Tested basic DFS mounts. I was facing setup issues while > > > > setting up DFS for failover. > > > > Steve will be running the buildbot DFS tests anyway, which will > > > > contain DFS failover. > > > > > > > > On Thu, May 19, 2022 at 12:45 AM Paulo Alcantara <pc@xxxxxx> wrote: > > > > > > > > > > Shyam Prasad N <nspmangalore@xxxxxxxxx> writes: > > > > > > > > > > > This time, I've verified that it does not break the multiuser > > > > > > scenario. :) > > > > > > > > > > Thanks! What about DFS failover scenario? :-) > > > > > > > > > > > > > > > > -- > > > > Regards, > > > > Shyam > > > > > > More fixes for multichannel: > > > > > > [PATCH] cifs: populate empty hostnames for extra channels > > > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/fb231a3e148e7537c899f4e145fc0dd876c2b195.patch > > > > > > [PATCH] cifs: change iface_list from array to sorted linked list > > > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/94363021b50edb86813ae280526d7f33d6903703.patch > > > > > > [PATCH] cifs: during reconnect, update interface if necessary > > > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/7610df44d276634a51155e6314ee159b7618013f.patch > > > > > > [PATCH] cifs: periodically query network interfaces from server > > > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/7dad71410514232501f921a8c3ad389d3344fddb.patch > > > > > > First one is a fix for ensuring that reconnect does not resolve extra > > > channels to possibly wrong IP address. > > > Rest three enable periodic query of server interfaces. This is > > > important for Azure service, where the server can change the IP > > > addresses of secondary channels. > > > > > > Reviews will be appreciated. > > > > > > -- > > > Regards, > > > Shyam > > > > Updated the last set of patches to the below set after fixing some > > coverity warnings. > > > > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/37d488b3d38c04f9f4caf1fab2b58301f0c20227.patch > > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/a21e72b2a9599482739884329523ed91cfabf8db.patch > > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/ad8f403ac707cf326371d1361ef5880d89b9bbe6.patch > > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/85ede3abb8348d3b9b5a2548c9773ed0fec0f157.patch > > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/8577d17e605634f297e1be71f602c8027737fefc.patch > > > > -- > > Regards, > > Shyam > > > > -- > Thanks, > > Steve Hi all, Found a race condition between the delayed workers when there's a failure to add a channel to a session. This was causing occasional failures on the buildbot due to a warning being logged. Fixed it with the below patch: https://github.com/sprasad-microsoft/smb3-kernel-client/commit/ff9ba549b08b8a54bd951e74dae7a1e74f8e7db6.patch Please review the fix. -- Regards, Shyam
