Looks good. Reviewed-by for both patches. On Thu, 9 Jun 2022 at 07:55, Enzo Matsumiya <ematsumiya@xxxxxxx> wrote: > > Hi, > > These 2 patches are a simple way to fix the DNS issue that > currently exists in cifs, where the upcall to key.dns_resolver will > always return 0 for the record TTL, hence, making the resolve worker > always use the default value SMB_DNS_RESOLVE_INTERVAL_DEFAULT > (currently 600 seconds). > > This also makes the new setting `dns_interval' user-configurable via > procfs (/proc/fs/cifs/dns_interval). > > One disadvantage here is that the interval is applied to all hosts > resolution. This is still how it works today, because we're always using > the default value anyway, but should someday this be fixed, then we can > go back to rely on the keys infrastructure to cache each hostname with > its own separate TTL. > > Please review and test. All feedback is welcome. > > > Cheers > > Enzo > > Enzo Matsumiya (2): > cifs: create procfs for dns_interval setting > cifs: reschedule DNS resolve worker based on dns_interval > > fs/cifs/cifs_debug.c | 63 +++++++++++++++++++++++++++++++++++++++++++ > fs/cifs/cifs_debug.h | 2 ++ > fs/cifs/cifsfs.c | 1 + > fs/cifs/connect.c | 4 +-- > fs/cifs/dns_resolve.c | 8 ++++++ > 5 files changed, 76 insertions(+), 2 deletions(-) > > -- > 2.36.1 >
