looks good reviewed by me On Thu, 2 Jun 2022 at 13:47, Steve French via samba-technical <samba-technical@xxxxxxxxxxxxxxx> wrote: > > Another minor one to remove some unneeded SMB20 code when legacy is disabled > > > On Wed, Jun 1, 2022 at 9:39 PM Steve French <smfrench@xxxxxxxxx> wrote: > > > > We should not be including unused SMB1/CIFS functions when legacy > > support is disabled (CONFIG_CIFS_ALLOW_INSECURE_LEGACY turned > > off), but especially obvious is not needing to build smb1ops.c > > at all when legacy support is disabled. Over time we can move > > more SMB1/CIFS and SMB2.0 legacy functions into ifdefs but this > > is a good start (and shrinks the module size a few percent). > > > > -- > > Thanks, > > > > Steve > > > > -- > Thanks, > > Steve
