On Tue, Mar 29, 2022 at 06:48:51PM -0700, Linus Torvalds wrote: > On Mon, Mar 28, 2022 at 6:39 PM Steve French <smfrench@xxxxxxxxx> wrote: > > > > - four patches relating to dentry race > > I took a look at this, and I absolutely hate it. > > You are basically exporting vfs-internal functions (__lookup_hash() in > particular) that really shouldn't be exported. It really shouldn't indeed, and I'm rather worried that this pull request just exports it without any relevant ACKs. > And the _reason_ you are exporting them seems to be that you have > copied most of do_renameat2() as ksmbd_vfs_rename() but then made > various small changes. > > This all makes me _very_ uncomfortable. > > I really get the feeling that we'd be much better off exporting > something that is just a bigger part of that rename logic, not that > really low-level __lookup_hash() thing. Agreed.
