Re: [PATCH] fix ksmbd bigendian bug in oplock break, and move its struct and a few others to smbfs_common

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2022-03-29 8:04 GMT+09:00, Steve French <smfrench@xxxxxxxxx>:
> Fix an endian bug in ksmbd for one remaining use of
> Persistent/VolatileFid that unnecessarily converted it (it is an
> opaque endian field that does not need to be and should not
> be converted) in oplock_break for ksmbd, and move the definitions
> for the oplock and lease break protocol requests and responses
> to fs/smbfs_common/smb2pdu.h
>
> Also move a few more definitions for various protocol requests
> that were duplicated (in fs/cifs/smb2pdu.h and fs/ksmbd/smb2pdu.h)
> into fs/smbfs_common/smb2pdu.h including:
>
> - various ioctls and reparse structures
> - validate negotiate request and response structs
> - duplicate extents structs
>
> See attachedcifs
Look good to me:)

Reviewed-by: Namjae Jeon <linkinjeon@xxxxxxxxxx>

Thanks!
>
> --
> Thanks,
>
> Steve
>



[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux