Looks good to me. Reviewed-by me On Mon, Mar 28, 2022 at 12:49 PM Steve French <smfrench@xxxxxxxxx> wrote: > > Updated patch to fix one place I missed pointed out by the kernel test robot. > > See attached. > > On Sun, Mar 27, 2022 at 4:14 PM Steve French <smfrench@xxxxxxxxx> wrote: > > > > Currently the way the tid (tree connection) status is tracked > > is confusing. The same enum is used for structs cifs_tcon > > and cifs_ses and TCP_Server_info, but each of these three has > > different states that they transition among. The current > > code also unnecessarily uses camelCase. > > > > Convert from use of statusEnum to a new tid_status_enum for > > tree connections. The valid states for a tid are: > > > > TID_NEW = 0, > > TID_GOOD, > > TID_EXITING, > > TID_NEED_RECON, > > TID_NEED_TCON, > > TID_IN_TCON, > > TID_NEED_FILES_INVALIDATE, /* unused, considering removing > > in future */ > > TID_IN_FILES_INVALIDATE > > > > It also removes CifsNeedTcon CifsInTcon CifsNeedFilesInvalidate and > > CifsInFilesInvalidate from the statusEnum used for session and > > TCP_Server_Info since they are not relevant for those. > > > > A follow on patch will fix the places where we use the > > tcon->need_reconnect flag to be more consistent with the tid->status > > > > See attached. > > > > Also FYI - Shyam had a work in progress patch to fix and clarify the > > ses->status enum > > > > -- > > Thanks, > > > > Steve > > > > -- > Thanks, > > Steve
