2022-03-27 11:29 GMT+09:00, Steve French <smfrench@xxxxxxxxx>:
> I think this was removed in the next patch (I don't see the warning,
> but presumably it is the blank line before the #endif at the end of
> the file?)
The change below is adding 2 blank lines.
+struct smb2_ioctl_rsp {
+ struct smb2_hdr hdr;
+ __le16 StructureSize; /* Must be 49 */
+ __le16 Reserved;
+ __le32 CtlCode;
+ __u64 PersistentFileId;
+ __u64 VolatileFileId;
+ __le32 InputOffset; /* Reserved MBZ */
+ __le32 InputCount;
+ __le32 OutputOffset;
+ __le32 OutputCount;
+ __le32 Flags;
+ __le32 Reserved2;
+ __u8 Buffer[];
+} __packed;
+
+
/* Possible InfoType values */
Thanks!
>
> On Sat, Mar 26, 2022 at 7:52 PM Namjae Jeon <linkinjeon@xxxxxxxxxx> wrote:
>>
>> 2022-03-27 2:59 GMT+09:00, Steve French <smfrench@xxxxxxxxx>:
>> > Updated the patch slightly to replace define that had Buffer[0] with
>> > Buffer[]
>> Minor nit, We can remove multiple blank lines in the patch.
>>
>> CHECK: Please don't use multiple blank lines
>> #390: FILE: fs/smbfs_common/smb2pdu.h:1124:
>> +
>> +
>>
>> Otherwise, Reviewed-by: Namjae Jeon <linkinjeon@xxxxxxxxxx>
>>
>> Thanks!
>> >
>> > On Sat, Mar 26, 2022 at 12:55 PM Steve French <smfrench@xxxxxxxxx>
>> > wrote:
>> >>
>> >> Move defines for ioctl protocol header and various size to
>> >> smbfs_common
>> >>
>> >> The definitions for the ioctl SMB3 request and response as well
>> >> as length of various fields defined in the protocol documentation
>> >> were duplicated in fs/ksmbd and fs/cifs. Move these to the common
>> >> code in fs/smbfs_common/smb2pdu.h
>> >>
>> >> See attached
>> >>
>> >>
>> >> --
>> >> Thanks,
>> >>
>> >> Steve
>> >
>> >
>> >
>> > --
>> > Thanks,
>> >
>> > Steve
>> >
>
>
>
> --
> Thanks,
>
> Steve
>
