2022-03-25 12:16 GMT+09:00, Steve French <smfrench@xxxxxxxxx>: > We have duplicated definitions for various SMB3 PDUs in > fs/ksmbd/smb2pdu.h and fs/cifs/smbpdu.h. Some had already > been moved to fs/smbfs_common/smb2pdu.h but there are more > to move. > > Move SMB3 definitions for > - error response > - query info request and response and various related protocol flags > - various lease handling flags and the create lease context > > to smbfs_common/smb2pdu.h to reduce code duplication > > (see attached patch) Looks good to me! Reviewed-by: Namjae Jeon <linkinjeon@xxxxxxxxxx> Thanks! > > -- > Thanks, > > Steve >