Re: [PATCH] cifs: use a different reconnect helper for non-cifsd threads

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Looks like it passed multichannel buildbot tests with the patch

http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/11/builds/180

On Tue, Feb 15, 2022 at 1:37 PM Steve French <smfrench@xxxxxxxxx> wrote:
>
> Updated and tentatively merged into cifs-2.6.git for-next and added acked-by
>
> Shyam,
> Let me know if any additional changes you see or feedback.
>
> On Tue, Feb 15, 2022 at 1:06 PM Paulo Alcantara <pc@xxxxxx> wrote:
> >
> > Hi Shyam,
> >
> > Shyam Prasad N <nspmangalore@xxxxxxxxx> writes:
> >
> > > My patch last week was not sufficient to fix some of the buildbot
> > > failures we saw recently.
> > > Please review and use the following patch for new buildbot runs.
> > >
> > > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/2b599dec7c9399b66b56419fcb252ab37de94e3b.patch
> >
> > Patch looks good, however you missed these:
> >
> > diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> > index 053cb449eb16..2e00cd58a8b5 100644
> > --- a/fs/cifs/connect.c
> > +++ b/fs/cifs/connect.c
> > @@ -4416,7 +4416,7 @@ static int tree_connect_dfs_target(const unsigned int xid, struct cifs_tcon *tco
> >          */
> >         if (rc && server->current_fullpath != server->origin_fullpath) {
> >                 server->current_fullpath = server->origin_fullpath;
> > -               cifs_reconnect(tcon->ses->server, true);
> > +               cifs_signal_cifsd_for_reconnect(server, true);
> >         }
> >
> >         dfs_cache_free_tgts(tl);
> > diff --git a/fs/cifs/netmisc.c b/fs/cifs/netmisc.c
> > index ebe236b9d9f5..235aa1b395eb 100644
> > --- a/fs/cifs/netmisc.c
> > +++ b/fs/cifs/netmisc.c
> > @@ -896,7 +896,7 @@ map_and_check_smb_error(struct mid_q_entry *mid, bool logErr)
> >                 if (class == ERRSRV && code == ERRbaduid) {
> >                         cifs_dbg(FYI, "Server returned 0x%x, reconnecting session...\n",
> >                                 code);
> > -                       cifs_reconnect(mid->server, false);
> > +                       cifs_signal_cifsd_for_reconnect(mid->server, false);
> >                 }
> >         }
> >
> > With that, feel free to add:
> >
> > Acked-by: Paulo Alcantara (SUSE) <pc@xxxxxx>
>
>
>
> --
> Thanks,
>
> Steve



-- 
Thanks,

Steve



[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux