2021-11-21 18:11 GMT+09:00, Oleksandr Natalenko <oleksandr@xxxxxxxxxxxxxx>: > Hello. > > On neděle 21. listopadu 2021 2:27:12 CET Namjae Jeon wrote: >> I attached the patch to fix this issue. >> You need to apply this patch to ksmbd-tools. >> >> Please check if your issue is fixed or not. :) > > I can confirm that with patched ksmbd-tools the issue is fixed. Thanks! > > As applicable, > > Reported-by: Olha Cherevyk <olha.cherevyk@xxxxxxxxx> > Tested-by: Oleksandr Natalenko <oleksandr@xxxxxxxxxxxxxx> The problem was fixed in an unexpected place. :) I can not fix this issue without your help. Really thank you very much! I will add your tags to the patch. Thanks again! > >> 2021-11-21 9:18 GMT+09:00, Namjae Jeon <linkinjeon@xxxxxxxxxx>: >> > I have reproduced this issue! >> > If you change share name from "Shared" to "shared", problem is improved >> > ? >> > Please try it after rebooting your windows PC. >> > >> > 2021-11-21 8:41 GMT+09:00, Namjae Jeon <linkinjeon@xxxxxxxxxx>: >> >> I have attached one more patch. >> >> >> >> Please apply it on the top of previous patches :) >> >> >> >> 2021-11-21 8:14 GMT+09:00, Oleksandr Natalenko >> >> >> >> <oleksandr@xxxxxxxxxxxxxx>: >> >>> On sobota 20. listopadu 2021 23:51:39 CET Namjae Jeon wrote: >> >>>> Thanks for your test and help:) >> >>>> I have attached 2 patches. you can apply them on the top of previous >> >>>> patch. please don't revert previous patches. >> >>>> >> >>>> no need to send tcpdump, please just check if problem is improved or >> >>>> not. >> >>> >> >>> The issue is still there after applying new 3 patches on top of old 3 >> >>> patches. >> >>> >> >>> Just in case, I've also collected the dump: [1]. >> >>> >> >>> [1] https://natalenko.name/myfiles/misc/ksmbd-4.pcap.gz >> >>> >> >>>> 2021-11-20 23:50 GMT+09:00, Oleksandr Natalenko >> >>>> >> >>>> <oleksandr@xxxxxxxxxxxxxx>: >> >>>> > On sobota 20. listopadu 2021 14:07:45 CET Namjae Jeon wrote: >> >>>> >> I probably found why default stream is not included in response. >> >>>> >> Please revert previous patches and apply attached patches. >> >>>> >> >> >>>> >> no need to check print log. if problem is still reproduced, >> >>>> >> please >> >>>> >> give me a tcpdump one more. >> >>>> > >> >>>> > Still no luck. The traffic dump is here: [1]. >> >>>> > >> >>>> > The only difference I've noticed is that in those "Unsupported >> >>>> > addition >> >>>> > info" >> >>>> > messages there's 0x20 only, and 0xf has disappeared. >> >>>> > >> >>>> > [1] https://natalenko.name/myfiles/misc/ksmbd-3.pcap.gz >> >>>> > >> >>>> >> 2021-11-20 21:46 GMT+09:00, Oleksandr Natalenko >> >>>> >> >> >>>> >> <oleksandr@xxxxxxxxxxxxxx>: >> >>>> >> > On sobota 20. listopadu 2021 1:46:16 CET Namjae Jeon wrote: >> >>>> >> >> >> > 1. ksmbd get stream info doesn't include default stream. >> >>>> >> >> >> >>>> >> >> ksmbd doesn't still include default stream(::DATA) in get >> >>>> >> >> stream >> >>>> >> >> info >> >>>> >> >> response. very stranged.. >> >>>> >> >> >> >>>> >> >> So I attached test patch that added print info in mail. Could >> >>>> >> >> you >> >>>> >> >> please check it and share print info to me ? >> >>>> >> > >> >>>> >> > Do I need to apply this patch only, or some previous patches >> >>>> >> > have >> >>>> >> > to >> >>>> >> > be >> >>>> >> > applied as well? If I apply this patch only, there's no extra >> >>>> >> > info >> >>>> >> > printed >> >>>> >> > in >> >>>> >> > the kernel log when I copy files from the share. >> >>>> >> > >> >>>> >> >> 2021-11-20 7:41 GMT+09:00, Oleksandr Natalenko >> >>>> >> >> >> >>>> >> >> <oleksandr@xxxxxxxxxxxxxx>: >> >>>> >> >> > On pátek 19. listopadu 2021 11:29:35 CET Namjae Jeon wrote: >> >>>> >> >> >> Could you please give a tcpdump me after applying attached >> >>>> >> >> >> patch >> >>>> >> >> >> ? >> >>>> >> >> > >> >>>> >> >> > It's here: [1]. The problem is still there with the patch >> >>>> >> >> > you've >> >>>> >> >> > sent >> >>>> >> >> > me >> >>>> >> >> > recently. >> >>>> >> >> > >> >>>> >> >> > [1] https://natalenko.name/myfiles/misc/ksmbd-2.pcap.gz >> >>>> >> >> > >> >>>> >> >> >> 2021-11-19 10:48 GMT+09:00, Namjae Jeon >> >>>> >> >> >> >> >>>> >> >> >> <linkinjeon@xxxxxxxxxx>: >> >>>> >> >> >> > Really thanks for your help! >> >>>> >> >> >> > >> >>>> >> >> >> > I found two difference. >> >>>> >> >> >> > >> >>>> >> >> >> > 1. ksmbd get stream info doesn't include default stream. >> >>>> >> >> >> > 2. samba return access denied error if addtion_info >> >>>> >> >> >> > contain >> >>>> >> >> >> > >> >>>> >> >> >> > SACL_SECINFO. >> >>>> >> >> >> > >> >>>> >> >> >> > Could you please check attached patch ? >> >>>> >> >> >> > >> >>>> >> >> >> > 2021-11-19 8:10 GMT+09:00, Oleksandr Natalenko >> >>>> >> >> >> > >> >>>> >> >> >> > <oleksandr@xxxxxxxxxxxxxx>: >> >>>> >> >> >> >> On čtvrtek 18. listopadu 2021 21:00:52 CET you wrote: >> >>>> >> >> >> >>> Thank you for your test! >> >>>> >> >> >> >>> >> >>>> >> >> >> >>> Could you please give me a tcpdump against samba ? >> >>>> >> >> >> >>> I would like to find any clue at that. >> >>>> >> >> >> >> >> >>>> >> >> >> >> Sure [3]. >> >>>> >> >> >> >> >> >>>> >> >> >> >> [3] https://natalenko.name/myfiles/misc/samba.pcap.gz >> >>>> >> >> >> >> >> >>>> >> >> >> >>> 2021-11-18 22:33 GMT+09:00, Oleksandr Natalenko >> >>>> >> >> >> >>> >> >>>> >> >> >> >>> <oleksandr@xxxxxxxxxxxxxx>: >> >>>> >> >> >> >>> > On čtvrtek 18. listopadu 2021 14:26:44 CET Oleksandr >> >>>> >> >> >> >>> > Natalenko >> >>>> >> >> >> >>> > >> >>>> >> >> >> >>> > wrote: >> >>>> >> >> >> >>> >> On čtvrtek 18. listopadu 2021 13:53:53 CET Namjae >> >>>> >> >> >> >>> >> Jeon >> >>>> >> >> >> >>> >> >> >>>> >> >> >> >>> >> wrote: >> >>>> >> >> >> >>> >> > I am trying to reproduce this issue on my setup. >> >>>> >> >> >> >>> >> > can't.. >> >>>> >> >> >> >>> >> > >> >>>> >> >> >> >>> >> > Could you please check attached patch again ? >> >>>> >> >> >> >>> >> > I remove AdditionalInformation flags check code >> >>>> >> >> >> >>> >> > not >> >>>> >> >> >> >>> >> > to >> >>>> >> >> >> >>> >> > happen >> >>>> >> >> >> >>> >> > "Unsupported addition info" error message. >> >>>> >> >> >> >>> >> >> >>>> >> >> >> >>> >> No luck, sorry, the issue is still there. The >> >>>> >> >> >> >>> >> messages >> >>>> >> >> >> >>> >> are >> >>>> >> >> >> >>> >> gone >> >>>> >> >> >> >>> >> from >> >>>> >> >> >> >>> >> the >> >>>> >> >> >> >>> >> kernel log on the server side though (as expected), >> >>>> >> >> >> >>> >> but >> >>>> >> >> >> >>> >> apparently >> >>>> >> >> >> >>> >> those >> >>>> >> >> >> >>> >> are >> >>>> >> >> >> >>> >> not directly related to the issue. >> >>>> >> >> >> >>> > >> >>>> >> >> >> >>> > And just to be on the safe side, I've re-tested it >> >>>> >> >> >> >>> > with >> >>>> >> >> >> >>> > Samba, >> >>>> >> >> >> >>> > and >> >>>> >> >> >> >>> > with >> >>>> >> >> >> >>> > Samba >> >>>> >> >> >> >>> > it just works. >> >>>> >> >> >> >>> > >> >>>> >> >> >> >>> > For reference, my Samba config is: >> >>>> >> >> >> >>> > >> >>>> >> >> >> >>> > ``` >> >>>> >> >> >> >>> > [global] >> >>>> >> >> >> >>> > workgroup = WORKGROUP >> >>>> >> >> >> >>> > server string = Samba Server %v >> >>>> >> >> >> >>> > netbios name = defiant >> >>>> >> >> >> >>> > name resolve order = host >> >>>> >> >> >> >>> > domain master = no >> >>>> >> >> >> >>> > load printers = no >> >>>> >> >> >> >>> > show add printer wizard = no >> >>>> >> >> >> >>> > printing = bsd >> >>>> >> >> >> >>> > printcap name = /dev/null >> >>>> >> >> >> >>> > disable spoolss = yes >> >>>> >> >> >> >>> > socket options = TCP_NODELAY SO_KEEPALIVE >> >>>> >> >> >> >>> > valid users = __guest >> >>>> >> >> >> >>> > >> >>>> >> >> >> >>> > [Shared] >> >>>> >> >> >> >>> > path = /mnt/shared >> >>>> >> >> >> >>> > force user = _shared >> >>>> >> >> >> >>> > force group = _shared >> >>>> >> >> >> >>> > browsable = no >> >>>> >> >> >> >>> > writeable = yes >> >>>> >> >> >> >>> > veto files = /lost+found/ >> >>>> >> >> >> >>> > ``` >> >>>> >> >> >> >>> > >> >>>> >> >> >> >>> > I fail to see any substantial difference here, so the >> >>>> >> >> >> >>> > issue >> >>>> >> >> >> >>> > must >> >>>> >> >> >> >>> > be >> >>>> >> >> >> >>> > hidden >> >>>> >> >> >> >>> > somewhere inside ksmbd. >> >>>> >> >> >> >>> > >> >>>> >> >> >> >>> > I'm still open for further testing, of course! > > -- > Oleksandr Natalenko (post-factum) > > >
