Re: [PATCH] ksmbd-tools: fix unit file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2021-11-04 1:20 GMT+09:00, Guillaume Castagnino <casta@xxxxxxxxxx>:
Cc: Enzo.

I will add the below description in patch header.

"Shell logic must be enclosed in shell subprocess, systemd cannot
handle it directly, so reload will fail."

> Signed-off-by: Guillaume Castagnino <casta@xxxxxxxxxx>
I will apply this patch, Enzo, Let me know if you have other opinion.

Thanks!
> ---
>  ksmbd.service | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ksmbd.service b/ksmbd.service
> index 5717177..3309fa9 100644
> --- a/ksmbd.service
> +++ b/ksmbd.service
> @@ -10,7 +10,7 @@ Group=root
>  RemainAfterExit=yes
>  ExecStartPre=-/sbin/modprobe ksmbd
>  ExecStart=/sbin/ksmbd.mountd -s
> -ExecReload=/sbin/ksmbd.control -s && /sbin/ksmbd.mountd
> +ExecReload=/bin/sh -c '/sbin/ksmbd.control -s && /sbin/ksmbd.mountd -s'
>  ExecStop=/sbin/ksmbd.control -s
>
>  [Install]
> --
> 2.33.1
>
>



[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux