Thinking about the patch "ksmbd: improve credits management" (https://github.com/smfrench/smb3-kernel/commit/bf8acc9e10e21c28452dfa067a7d31e6067104b1) Hyunchul noted in the description: "Windows server 2016 or later grant up to 8192 credits to clients at once." I noticed that SMB2_MAX_CREDITS is defined as 8192 in fs/ksmbd/smb2pdu.h. Isn't this a little low, although I see Samba default to it as well. Was thinking that that is roughly equivalent to 64 8MB writes, or 128 4MB writes. Although Samba defaults to 8192 max credits as well, for Samba it is configurable (via "smb2 max credits" in smb.conf). Should it be configurable? What do more current Windows servers default to as the max? -- Thanks, Steve
