On Thu, Oct 07, 2021 at 09:37:04PM +0900, Namjae Jeon wrote:
> 2021-10-07 20:47 GMT+09:00, Colin King <colin.king@xxxxxxxxxxxxx>:
> >
> > Fixes: e2f34481b24d ("cifsd: add server-side procedures for SMB3")
> I think that this alarm is caused by b66732021c64 (ksmbd: add
> validation in smb2_ioctl).
> Fixes tag may be not needed. Because b66732021c64 patch is not applied
> to Linus' tree yet ?
If you are going to modify the commit to include this fix then that's
fine. Otherise if you are going to apply this commit then the Fixes
tag is still required.
The fixes tag saves time for backporters because they can automatically
rule out that this patch needs to be backported. Or if they backport
commit b66732021c64 then they know they have to backport the fix as
well.
Also the Fixes tag is used for other purposes besides backporting.
It helps review. It's also an interesting metric to measure how long
between the bug is introduced and the fix is applied.
regards,
dan carpenter
