2021-10-06 17:43 GMT+09:00, Hyunchul Lee <hyc.lee@xxxxxxxxx>: > 2021년 10월 6일 (수) 오후 4:15, Ralph Boehme <slow@xxxxxxxxx>님이 작성: >> >> Am 05.10.21 um 12:00 schrieb Hyunchul Lee: >> > * For an asynchronous operation, grant credits >> > for an interim response and 0 credit for the >> > final response. >> >> fwiw, Samba also does this but this can cause significant problems as it >> means the server looses control over the receive window size. We've seen >> aggressive client go nuts about this overwhelming the server with IO >> requests leading to disconnects (iirc). So this may need careful >> checking how Windows implements this server side. >> > > Okay, I will drop this in the patch. And could you elaborate > on the situation that clients cause the problem? > > Namjae, What do you think about Ralph's comment? Let's remove async codes in this patch. I would like to know how I verified this code. i.e. not xfstests, Client attack that runs out of credits of ksmbd... Should it be tested by change the credit management of the cifs client or libsmb2? Thanks! > > Thank you for your comments! > >> Cheers! >> -slow >> >> -- >> Ralph Boehme, Samba Team https://samba.org/ >> SerNet Samba Team Lead https://sernet.de/en/team-samba > > > > -- > Thanks, > Hyunchul >
