Typically kernel style encourages even a brief description in all changesets (even trivial ones) e.g. "Simplifies message parsing slightly. No change in behavior" On Mon, Oct 4, 2021 at 11:29 PM Ralph Boehme <slow@xxxxxxxxx> wrote: > > Am 03.10.21 um 02:59 schrieb Namjae Jeon: > > 2021-10-02 22:12 GMT+09:00, Ralph Boehme <slow@xxxxxxxxx>: > >> No change in behaviour. > > It is better to add patch subject here if there is nothing to write > > patch description. > > i.e. "Use ksmbd_req_buf_next() in ksmbd_smb2_check_message()" > See the mail subject, that's the patch subject. > > In Samba we often help reviewers reviewing large patchsets that may > include a lot of small preparational/cleanup patches with a sentence > like "No change in behaviour" to give a hint which patches are critical > and need extra care when reviewing (ie all others) and which may not > require this. > > -slow > > -- > Ralph Boehme, Samba Team https://samba.org/ > SerNet Samba Team Lead https://sernet.de/en/team-samba -- Thanks, Steve
