2021-09-30 2:18 GMT+09:00, Ralph Boehme <slow@xxxxxxxxx>: > Am 29.09.21 um 19:11 schrieb Steve French: >> gitnub is fine for many things, and we can automated "kernel >> development process" >> things presumably with github easier than alternatives: >> - running "scripts/checkpatch" >> - make with C=1 and "_CHECK_ENDIAN" support turned on >> - kick off smbtorture tests (as Namjae already does in his branches in >> github) > > you can also add "doing review". :) > > As for running tests: I want that as well! :) How can I get that? Maybe > other want to run CI on their patches too before posting them. > >> BUT ... we have to ensure a couple things. >> - we don't annoy Linus (and linux-next and stable maintainers) by doing >> things >> like web merges in github (he complained about the >> meaningless/distracting >> github web ui empty merge messages) > > as said before: just don't do the merge there, just the review. That's > the way Samba has been doing it for years. Are you actually aware of the > current Samba workflow? Is it friendly to new developers? I know samba workflow now too. New developers can do everything easily by simply subscribing to the mailing list. And do we review only the SMB protocol on github? If we review and discuss kernel common code usage and touching, it should be visible to the component kernel maintainers as well. And is the review history likely to be discarded on github? Doesn't it get thrown away the moment you change or update a patch? Also, review discussions left on each individual's github cannot be easily searched like mailing list. > > -slow > > -- > Ralph Boehme, Samba Team https://samba.org/ > SerNet Samba Team Lead https://sernet.de/en/team-samba >
