2021-09-28 23:23 GMT+09:00, Namjae Jeon <linkinjeon@xxxxxxxxxx>: > 2021-09-28 22:43 GMT+09:00, Ralph Boehme <slow@xxxxxxxxx>: >> Am 28.09.21 um 05:26 schrieb Ralph Boehme: >>> both: there are issues with the patch and I have changes on-top. :) It >>> just takes a bit of time due to other stuff going on currently like SDC. >> >> finally... :) >> >> Please check my branch >> <https://github.com/slowfranklin/smb3-kernel/commits/ksmbd-for-next-pending> >> >> for added commits and two SQUASHes. Remaining commits reviewed-by: me. > Yep, looks good, I will update them in patches. And thanks for your review! When I take a look, I found issues in two squashes. I leave comments... I still prefer you give review comments on patches in the list. >> >> Oh, and I also split out the setinfo basic infolevel changes into its >> own commit. > If you want to add clean-up patch first, we can change > get_file_basic_info() together in patch. I will update it also. >> >> Let me know what you think of the additional checks I've added. > You should submit patches to the list to be checked by other developers. > > Thanks! >> >> Cheers! >> -slow >> >> -- >> Ralph Boehme, Samba Team https://samba.org/ >> SerNet Samba Team Lead https://sernet.de/en/team-samba >> >
