2021-09-22 22:39 GMT+09:00, Ralph Boehme <slow@xxxxxxxxx>:
> Hi Namjae,
>
> patch looks great. One nitpick.
>
> Am 22.09.21 um 06:19 schrieb Namjae Jeon:
>> Add buffer validation in smb2_set_info, and remove unused variable
>> in set_file_basic_info. and smb2_set_info infolevel functions take
>> structure pointer argument.
>> ...
>> +struct smb2_file_basic_info { /* data block encoding of response to level
>> 18 */
>> + __le64 CreationTime; /* Beginning of FILE_BASIC_INFO equivalent */
>> + __le64 LastAccessTime;
>> + __le64 LastWriteTime;
>> + __le64 ChangeTime;
>> + __le32 Attributes;
>> + __u32 Pad1; /* End of FILE_BASIC_INFO_INFO equivalent */
>> +} __packed;
>> +
>
> adding struct smb2_file_basic_info and the fix in the handler should be
> done in a preceeding commit.
Well, This structure is added for buffer check. There is no problem
using smb2_file_all_info as before if there is no buffer check.
Thanks!
>
> Thanks!
> -slow
>
> --
> Ralph Boehme, Samba Team https://samba.org/
> SerNet Samba Team Lead https://sernet.de/en/team-samba
>
>
