On Mon, Sep 20, 2021 at 9:44 AM Ralph Boehme <slow@xxxxxxxxx> wrote: > > Am 19.09.21 um 04:13 schrieb Namjae Jeon: > > Use LOOKUP_NO_SYMLINKS flags for default lookup to prohibit the > > middle of symlink component lookup. > > maybe this patch should be squashed with the "ksmbd: remove follow > symlinks support" patch? These two could be merged if it makes review easier or less likely to cause merge conflicts later (in this case that may be true since they both touch smb2_open), but that assumes that removing ability to follow all symlinks is agreed upon. Removing the ability to follow symlinks may be preferable, but I can imagine cases where the admin is exporting only via SMB3 or only read only where symlinks could be of value inside a share and safe (if remote users can't create symlinks outside the share). I don't have a strong opinion but also can imagine cases where symlinks could be required (share exported by both nfs and smb3 e.g.) but obviously checked to avoid escaping from the share. -- Thanks, Steve
