Hi Ronnie,
> @@ -2525,9 +2525,7 @@ int smb2_open(struct ksmbd_work *work)
> req->CreateOptions & FILE_RANDOM_ACCESS_LE)
> req->CreateOptions = ~(FILE_SEQUENTIAL_ONLY_LE);
>
> - if (req->CreateOptions &
> - (FILE_OPEN_BY_FILE_ID_LE | CREATE_TREE_CONNECTION |
> - FILE_RESERVE_OPFILTER_LE)) {
> + if (req->CreateOptions & FILE_OPEN_BY_FILE_ID_LE) {
Is there any reason to remove CREATE_TREE_CONNECTION and
FILE_RESERVE_OPFILTER_LE check here ?
smb2.create.gentest failed by removing this check.
test: gentest
time: 2021-09-08 07:04:21.276746
time: 2021-09-08 07:04:21.413606
failure: gentest [
(../../source4/torture/smb2/create.c:222) Incorrect value for ok_mask
0x00ffcffe - should be 0x00efcf7e
]
The command "./bin/smbtorture //127.0.0.1/cifsd-test3/ -Utestuser%1234
smb2.create.gentest" exited with 1.
> @@ -3475,9 +3473,9 @@ static int smb2_populate_readdir_entry(struct
> ksmbd_conn *conn, int info_level,
> posix_info->Mode = cpu_to_le32(ksmbd_kstat->kstat->mode);
> posix_info->Inode = cpu_to_le64(ksmbd_kstat->kstat->ino);
> posix_info->DosAttributes =
> - S_ISDIR(ksmbd_kstat->kstat->mode) ? ATTR_DIRECTORY_LE :
> ATTR_ARCHIVE_LE;
> + S_ISDIR(ksmbd_kstat->kstat->mode) ? FILE_ATTRIBUTE_DIRECTORY_LE :
> FILE_ATTRIBUTE_ARCHIVE_LE;
checkpatch.pl error happen.
WARNING: line length of 116 exceeds 100 columns
#274: FILE: fs/ksmbd/smb2pdu.c:3476:
+ S_ISDIR(ksmbd_kstat->kstat->mode) ? FILE_ATTRIBUTE_DIRECTORY_LE :
FILE_ATTRIBUTE_ARCHIVE_LE;
I can directly update this patch, so no need to send v2 patch.
Thanks!
