The smbfsctl.h should also be easy to move ... but the obvious question is whether "common" headers belong in "fs/cifs_common" or in include/linux ... (as e.g. nfs does with common headers between server and client) On Thu, Sep 2, 2021 at 6:37 PM Ronnie Sahlberg <lsahlber@xxxxxxxxxx> wrote: > > Steve, > > Here is an initial set of patches that starts moving SMB2 PDU definitions > from the client/server into a shared smb2pd.h file. > > It moves the command opcode values into cifs_common, > it renames cifs smb2_sync_hdr to smb2_hdr to harmonize with ksmbd naming > and it moves the tree connect and disconnect PDU definitions to the shared > file. > > > -- Thanks, Steve