On Thu 19-08-21 10:34:32, Pali Rohár wrote: > On Friday 13 August 2021 15:48:22 Jan Kara wrote: > > On Thu 12-08-21 17:51:34, Pali Rohár wrote: > > > On Thursday 12 August 2021 16:17:36 Jan Kara wrote: > > > > On Sun 08-08-21 18:24:36, Pali Rohár wrote: > > > > > Currently iocharset=utf8 mount option is broken. To use UTF-8 as iocharset, > > > > > it is required to use utf8 mount option. > > > > > > > > > > Fix iocharset=utf8 mount option to use be equivalent to the utf8 mount > > > > > option. > > > > > > > > > > If UTF-8 as iocharset is used then s_nls_map is set to NULL. So simplify > > > > > code around, remove UDF_FLAG_NLS_MAP and UDF_FLAG_UTF8 flags as to > > > > > distinguish between UTF-8 and non-UTF-8 it is needed just to check if > > > > > s_nls_map set to NULL or not. > > > > > > > > > > Signed-off-by: Pali Rohár <pali@xxxxxxxxxx> > > > > > > > > Thanks for the cleanup. It looks good. Feel free to add: > > > > > > > > Reviewed-by: Jan Kara <jack@xxxxxxx> > > > > > > > > Or should I take this patch through my tree? > > > > > > Hello! Patches are just RFC, mostly untested and not ready for merging. > > > I will wait for feedback and then I do more testing nad prepare new > > > patch series. > > > > OK, FWIW I've also tested the UDF and isofs patches. > > Well, if you have already done tests, patches are correct and these fs > driver are working fine then fell free to take it through your tree. > > I just wanted to warn people that patches in this RFC are mostly > untested to prevent some issues. But if somebody else was faster than > me, did testing + reviewing and there was no issue, I do not see any > problem with including them. Just I cannot put my own Tested-by (yet) :-) OK, I've pulled the udf and isofs fixes to my tree. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
