Goal of these patches makes sense. Also will make it easier to build without SMB1 in the future when required. On Fri, Aug 13, 2021 at 2:57 PM Ronnie Sahlberg <lsahlber@xxxxxxxxxx> wrote: > > Steve, list > > These three patches moves smb1 and all functions that depend on DES > into smb1ops.c and will optionally compile smb1ops.c iff SMB1 support > is enabled (CONFIG_CIFS_ALLOW_INSECURE_LEGACY) > > Additionally, make CONFIG_CIFS_ALLOW_INSECURE_LEGACY depend on > CONFIG_LIB_DES so that if the kernel is built without DES support > we automatically disable the smb1 protocol. > > > This allows to build a cifs module on a kernel where DES has been disabled. > > > -- Thanks, Steve