Should we make the error noisier? Perhaps we could add a dynamic trace point for failed id mappings so we could debug these if problems with the upcall, malformed ids/SIDs etc? On Tue, Jun 22, 2021 at 5:18 AM Aurélien Aptel <aaptel@xxxxxxxx> wrote: > > Steve French <smfrench@xxxxxxxxx> writes: > > Any thoughts on whether it would be better to return the errors, or > > continue the current strategy of simply using the default uid/gid for > > the mount and returning 0 (and removing the two places above where we > > set rc to non zero values, since rc will be overwritten with 0)? > > My opinion: I think best-effort would be better, so returning things as > default uid/gid (or possibly root). > > Cheers, > -- > Aurélien Aptel / SUSE Labs Samba Team > GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 > SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE > GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München) > -- Thanks, Steve
