Looking through the PR - agree with Aurelien's comments (mostly minor) On Wed, Jun 2, 2021 at 10:57 AM Aurélien Aptel <aaptel@xxxxxxxx> wrote: > > Hi Shyam, > > We've already discussed how to go about it so your changes LGTM. > I've added some minor comments on your github pull request. > > Shyam Prasad N <nspmangalore@xxxxxxxxx> writes: > > P.S. There is a logic in cifs_reconnect to switch between the targets > > for the server. I don't think these changes will break the DFS > > scenario. The code will likely take effect only for when the primary > > channel reconnects (as DFS server entries are cached with super block > > as the key). Perhaps more changes will be needed there to also switch > > between the targets for individual channels (maybe use superblock + > > channel num as the key for caching entries?). Folks with better > > knowledge than me with this code may want to check on this? > > You need to talk with Paulo for this. He has just sent a rewrite of the > cache yday. > > > @Steve French It'll be good to let a few cycles of buildbot to run > > with this code, before submitting to upstream. I have run a bunch of > > tests with this. However, more soak time will be safer. > > We need more tests on the buildbot so if you have things for mchan we > can run on it please add it there. > > Cheers, > -- > Aurélien Aptel / SUSE Labs Samba Team > GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 > SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE > GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München) > -- Thanks, Steve
