Re: [PATCH v2] cifs: decoding negTokenInit with generic ASN1 decoder

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hyunchul,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on cifs/for-next]
[also build test WARNING on linux/master linus/master v5.13-rc2 next-20210521]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Hyunchul-Lee/cifs-decoding-negTokenInit-with-generic-ASN1-decoder/20210522-232614
base:   git://git.samba.org/sfrench/cifs-2.6.git for-next
config: i386-defconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/e1097df7e174530fece6a8afc49d61d34b904869
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Hyunchul-Lee/cifs-decoding-negTokenInit-with-generic-ASN1-decoder/20210522-232614
        git checkout e1097df7e174530fece6a8afc49d61d34b904869
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> fs/cifs/asn1.c:11:1: warning: no previous prototype for 'decode_negTokenInit' [-Wmissing-prototypes]
      11 | decode_negTokenInit(unsigned char *security_blob, int length,
         | ^~~~~~~~~~~~~~~~~~~


vim +/decode_negTokenInit +11 fs/cifs/asn1.c

     9	
    10	int
  > 11	decode_negTokenInit(unsigned char *security_blob, int length,
    12			    struct TCP_Server_Info *server)
    13	{
    14		if (asn1_ber_decoder(&spnego_negtokeninit_decoder, server,
    15				     security_blob, length) == 0)
    16			return 1;
    17		else
    18			return 0;
    19	}
    20	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux