merged into cifs-2.6.git for-next and cc:stable v5.12 On Fri, May 21, 2021 at 1:37 PM Steve French <smfrench@xxxxxxxxx> wrote: > > On Fri, May 21, 2021 at 2:52 AM Shyam Prasad N <nspmangalore@xxxxxxxxx> wrote: > > > > Can you please verify with this patch? > > > > We missed using the variable length string macros in several > > tracepoints. Fixed them in this change. > > > > There's probably more useful macros that we can use to print > > others like flags etc. But I'll submit seperate patches for > > those at a future date. > > > > https://github.com/sprasad-microsoft/smb-kernel-client/commit/ce6399dd4f13cacc4ffdc41e07cde5cc88175f71.patch > > https://github.com/sprasad-microsoft/smb-kernel-client/pull/2 > > > > Regards, > > Shyam > > Yes - it works now > > # trace-cmd show > # tracer: nop > # > # entries-in-buffer/entries-written: 1/1 #P:12 > # > # _-----=> irqs-off > # / _----=> need-resched > # | / _---=> hardirq/softirq > # || / _--=> preempt-depth > # ||| / delay > # TASK-PID CPU# |||| TIMESTAMP FUNCTION > # | | | |||| | | > cifsd-226090 [000] .... 386914.150292: smb3_reconnect: > conn_id=0x1 server=localhost current_mid=26 > > > > On Thu, May 20, 2021 at 11:41 PM Steve French <smfrench@xxxxxxxxx> wrote: > > > > > > Looks like we have a bug in how we dump server name in some > > > tracepoints e.g. see below: > > > > > > smfrench@smfrench-ThinkPad-P52:~/cifs-2.6$ sudo trace-cmd show > > > # tracer: nop > > > # > > > # entries-in-buffer/entries-written: 1/1 #P:12 > > > # > > > # _-----=> irqs-off > > > # / _----=> need-resched > > > # | / _---=> hardirq/softirq > > > # || / _--=> preempt-depth > > > # ||| / delay > > > # TASK-PID CPU# |||| TIMESTAMP FUNCTION > > > # | | | |||| | | > > > cifsd-82671 [006] .... 298870.051187: smb3_reconnect: > > > conn_id=0x2 server=(0xffff950d5f6f6c00:localhost)[UNSAFE-MEMORY] > > > current_mid=3105 > > > > > > > > > -- > > > Thanks, > > > > > > Steve > > > > > > > > -- > > Regards, > > Shyam > > > > -- > Thanks, > > Steve -- Thanks, Steve
