Re: [PATCH][SMB3] 3 small multichannel client patches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Reviewed-by: Shyam Prasad N <sprasad@xxxxxxxxxxxxx>
... for all three patches.

For 0003, logging is okay for now. However, when we have a way to pass
custom messages to userspace with new mount API, we should have this
message there too.

Regards,
Shyam

On Sat, May 8, 2021 at 6:43 AM Steve French <smfrench@xxxxxxxxx> wrote:
>
> 1) we were not setting CAP_MULTICHANNEL on negotiate request
> 2) we were ignoring whether the server set CAP_NEGOTIATE in the response
> 3) we were silently ignoring multichannel when "max_channels" was > 1
> but the user forgot to include "multichannel" in mount line.
>
>
>
> --
> Thanks,
>
> Steve



-- 
Regards,
Shyam



[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux