Re: [PATCH v2] cifs: fix regression when mounting shares with prefix paths

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



David Disseldorp <ddiss@xxxxxxx> writes:

> On Mon,  3 May 2021 11:55:26 -0300, Paulo Alcantara wrote:
>> -	rc = cifs_setup_volume_info(cifs_sb->ctx, NULL, old_ctx->UNC);
>> +	rc = cifs_setup_volume_info(cifs_sb->ctx, NULL, NULL);
>
> IIUC, with the new behaviour, this call becomes pretty much an
> 	if (!cifs_sb->ctx->username)
> 		root = ERR_PTR(-EINVAL);

Yeah.  We should get rid of the damn thing at some point.  I've just
tried to keep the logic we currently have in fs/cifs/connect.c by
composing new options based upon the chased DFS referrals.

Thanks for pointing it out!



[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux