Yep - good catch. It is missing part of my patch :( Ugh Will need to rerun and get real numbers On Sat, Apr 24, 2021 at 9:10 PM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > > On Sat, Apr 24, 2021 at 02:27:11PM -0500, Steve French wrote: > > Using the buildbot test systems, this resulted in an average improvement > > of 14% to the Windows server test target for the first 12 tests I > > tried (no multichannel) > > changing to 12MB rasize (read ahead size). Similarly increasing the > > rasize to 12MB to Azure (this time with multichannel, 4 channels) > > improved performance 37% > > > > Note that Ceph had already introduced a mount parameter "rasize" to > > allow controlling this. Add mount parameter "rasize" to cifs.ko to > > allow control of read ahead (rasize defaults to 4MB which is typically > > what it used to default to to the many servers whose rsize was that). > > I think something was missing from this patch -- I see you parse it and > set it in the mount context, but I don't see where it then gets used to > actually affect readahead. -- Thanks, Steve