Re: [PATCH] cifs: On cifs_reconnect, resolve the hostname again.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Aurélien,

That logic is already there.
If reconn_set_ipaddr_from_hostname() returns failure, we log it and
continue with the reconnect to the old server->dstaddr anyway,

Regards,
Shyam

On Thu, Apr 8, 2021 at 2:11 PM Aurélien Aptel <aaptel@xxxxxxxx> wrote:
>
> Shyam Prasad N <nspmangalore@xxxxxxxxx> writes:
> > The intel bot identified an issue with the earlier version of the fix,
> > when not compiled with DFS.
> > Here's an updated version with that fix too.
>
> Ah I guess that's why resolving wasn't done on reconnect outside of DFS:
> it requires the DNS resolver which requires upcalling i.e. having
> keys-utils, request-conf.conf and dns_resolver key installed and
> properly configured on the system to be able to reconnect.
>
> Maybe we should fallback to retrying the same ip if resolving isn't
> available.
>
> Cheers,
> --
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
> SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
> GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
>


-- 
Regards,
Shyam




[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux