Re: [Linux-cifsd-devel] [PATCH] cifsd: use kfree to free memory allocated by kzalloc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/1/2021 9:36 AM, Namjae Jeon wrote:
2021-04-01 22:14 GMT+09:00, Ralph Boehme <slow@xxxxxxxxx>:
Am 4/1/21 um 2:59 PM schrieb Namjae Jeon:
2021-04-01 21:50 GMT+09:00, Ralph Boehme <slow@xxxxxxxxx>:
fwiw, while at it what about renaming everything that still references
"cifs" to "smb" ? This is not the 90's... :)
It is also used with the name "ksmbd". So function and variable prefix
are used with ksmbd.

well, I was thinking of this:

  > +++ b/fs/cifsd/...

We should really stop using the name cifs for modern implementation of
SMB{23} and the code should not be added as fs/cifsd/ to the kernel.
As I know, currently "cifs" is being used for the subdirectory name
for historical reasons and to avoid confusions, even though the CIFS
(SMB1) dialect is no longer recommended.

I'm with Ralph. CIFS is history that we need to relegate to the past.

I also agree that wrappers around core memory allocators are to
be avoided.

Tom.



[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux