Re: [PATCH] cifs: Adjust key sizes and key generation routines for AES256 encryptions.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Reviewed-by: Ronnie Sahlberg <lsahlber@xxxxxxxxxx>

Handling all the keys as 32byte arrays internally should be fine
but for the cifs_dbg() output I think you should add a conditional and
print them either as 16 or 32 bytes, not always as 32 bytes.

I.e. don't print the 16 byte padding for the aes128 cases.

On Thu, Mar 25, 2021 at 11:08 PM Shyam Prasad N <nspmangalore@xxxxxxxxx> wrote:
>
> Aargh. Here goes... :)
>
> On Thu, Mar 25, 2021 at 6:29 PM ronnie sahlberg
> <ronniesahlberg@xxxxxxxxx> wrote:
> >
> > -ENOPATCH ?
> >
> > On Thu, Mar 25, 2021 at 10:53 PM Shyam Prasad N <nspmangalore@xxxxxxxxx> wrote:
> > >
> > > Hi Steve,
> > >
> > > Please include this fix for AES 256 encryption algorithm based mounts.
> > > I've validated this by mounting and performing I/O.
> > >
> > > --
> > > Regards,
> > > Shyam
>
>
>
> --
> Regards,
> Shyam



[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux