Test 317 will require additional changes for test 317 when run with cifsacl (to map ownership) or will need to be run with winbind or sssd - but I verified that it does fix test 317 for idsfromsid,modefromsid On Wed, Mar 10, 2021 at 11:58 AM Rohith Surabattula <rohiths.msft@xxxxxxxxx> wrote: > > Looks good to me. > Reviewed-by: Rohith Surabattula <rohiths@xxxxxxxxxxxxx> > > On Wed, Mar 10, 2021 at 11:14 PM Shyam Prasad N <nspmangalore@xxxxxxxxx> wrote: > > > > Hi Steve, > > > > Please consider this fix for the failing generic/317 test for cifsacl > > and idsfromsid,modefromsid. > > This is exposed on certain combinations of default ACEs on the file. > > > > -- > > Regards, > > Shyam -- Thanks, Steve