чт, 18 февр. 2021 г. в 08:10, Rohith <rohiths.msft@xxxxxxxxx>:
>
> Hi Pavel,
>
>
>
> Addressed review comments. Can you please take a look.
>
>
>
> >> Btw, I think is_status_io timeout should be called in this loop for
>
> >> every mid not outside the loop (sorry, missed that in the original
>
> >> review). Could you please fix that separately?
>
>
>
> Yes, will send out different patch for status_io_timeout.
Thanks!
The patch looks good. Please find my minor comments below:
1.
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 10fe6d6d2dee..b2f51546c2ef 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -993,6 +993,10 @@ cifs_demultiplex_thread(void *p)
if (mids[i] != NULL) {
mids[i]->resp_buf_size = server->pdu_size;
+ if (server->ops->is_network_name_deleted) {
+ server->ops->is_network_name_deleted(bufs[i],
+ server);
+ }
^^^
remove extra {}
2.
+static void
+smb2_is_network_name_deleted(char *buf, struct TCP_Server_Info *server)
+{
+ struct smb2_sync_hdr *shdr = (struct smb2_sync_hdr *)buf;
+ struct list_head *tmp, *tmp1;
+ struct cifs_ses *ses;
+ struct cifs_tcon *tcon;
+
+ if (shdr->Status == STATUS_NETWORK_NAME_DELETED) {
^^^
let's do the opposite check: if status is not
STATUS_NETWORK_NAME_DELETED then return immediately from the function.
This will remove overall indentation for the nested for loops.
3.
@@ -4605,6 +4632,10 @@ static void smb2_decrypt_offload(struct
work_struct *work)
#ifdef CONFIG_CIFS_STATS2
mid->when_received = jiffies;
#endif
+ if (dw->server->ops->is_network_name_deleted) {
+ dw->server->ops->is_network_name_deleted(dw->buf,
+ dw->server);
+ }
^^^
remove extra {}
--
Best regards,
Pavel Shilovsky
