Re: [PATCH 02/33] mm: Add an unlock function for PG_private_2/PG_fscache

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: David Howells <dhowells@xxxxxxxxxx>
Subject: Re: [PATCH 02/33] mm: Add an unlock function for PG_private_2/PG_fscache
From: Christoph Hellwig <hch@xxxxxx>
Date: Tue, 16 Feb 2021 11:26:59 +0100
Cc: Trond Myklebust <trondmy@xxxxxxxxxxxxxxx>, Anna Schumaker <anna.schumaker@xxxxxxxxxx>, Steve French <sfrench@xxxxxxxxx>, Dominique Martinet <asmadeus@xxxxxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, linux-mm@xxxxxxxxx, linux-cachefs@xxxxxxxxxx, linux-afs@xxxxxxxxxxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, linux-cifs@xxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, v9fs-developer@xxxxxxxxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, Jeff Layton <jlayton@xxxxxxxxxx>, David Wysochanski <dwysocha@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <161340387944.1303470.7944159520278177652.stgit@warthog.procyon.org.uk>
References: <161340385320.1303470.2392622971006879777.stgit@warthog.procyon.org.uk> <161340387944.1303470.7944159520278177652.stgit@warthog.procyon.org.uk>
User-agent: Mutt/1.5.17 (2007-11-01)

> +extern void unlock_page_private_2(struct page *page);

No need for the extern.

Otherwise this looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH 00/33] Network fs helper library & fscache kiocb API [ver #3]
  - From: David Howells
- [PATCH 02/33] mm: Add an unlock function for PG_private_2/PG_fscache
  - From: David Howells

Prev by Date: Re: [PATCH 04/33] vfs: Export rw_verify_area() for use by cachefiles
Next by Date: Re: [PATCH 03/33] mm: Implement readahead_control pageset expansion
Previous by thread: [PATCH 02/33] mm: Add an unlock function for PG_private_2/PG_fscache
Next by thread: [PATCH 01/33] iov_iter: Add ITER_XARRAY
Index(es):
- Date
- Thread

[Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]