Re: [SMB3][Multichannel] avoid confusing warning message on mount to Azure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Reviewed-by: Ronnie Sahlberg <lsahlber@xxxxxxxxxx>

On Wed, Dec 9, 2020 at 1:22 PM Steve French <smfrench@xxxxxxxxx> wrote:
>
> Mounts to Azure cause an unneeded warning message in dmesg
>    "CIFS: VFS: parse_server_interfaces: incomplete interface info"
>
> Azure rounds up the size (by 8 additional bytes, to a
> 16 byte boundary) of the structure returned on the query
> of the server interfaces at mount time.  This is permissible
> even though different than other servers so do not log a warning
> if query network interfaces response is only rounded up by 8
> bytes or fewer.
>
> CC: Stable <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Steve French <stfrench@xxxxxxxxxxxxx>
> ---
>  fs/cifs/smb2ops.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
> index 3d914d7d0d11..22f1d8dc12b0 100644
> --- a/fs/cifs/smb2ops.c
> +++ b/fs/cifs/smb2ops.c
> @@ -477,7 +477,8 @@ parse_server_interfaces(struct
> network_interface_info_ioctl_rsp *buf,
>   goto out;
>   }
>
> - if (bytes_left || p->Next)
> + /* Azure rounds the buffer size up 8, to a 16 byte boundary */
> + if ((bytes_left > 8) || p->Next)
>   cifs_dbg(VFS, "%s: incomplete interface info\n", __func__);
>
>
> --
> Thanks,
>
> Steve



[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux