Re: [PATCH] smb3: set COMPOUND_FID to FileID field of subsequent compound request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



updated ... also just noticed that no need for cc:stable since this
was added after 5.9

On Thu, Dec 3, 2020 at 3:23 PM ronnie sahlberg <ronniesahlberg@xxxxxxxxx> wrote:
>
> Looks good to me,
> please add "Reviewed-by: Ronnie Sahlberg <lsahlber@xxxxxxxxxx>"
>
> (How could this ever have worked?)
>
>
> Can you add a line :
> Fixes: 2e4564b31b645 ("smb3: add support ....
>
> On Thu, Dec 3, 2020 at 1:38 PM Namjae Jeon <namjae.jeon@xxxxxxxxxxx> wrote:
> >
> > For an operation compounded with an SMB2 CREATE request, client must set
> > COMPOUND_FID(0xFFFFFFFFFFFFFFFF) to FileID field of smb2 ioctl.
> >
> > Signed-off-by: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
> > ---
> >  fs/cifs/smb2ops.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
> > index 504766cb6c19..3ca632bb6be9 100644
> > --- a/fs/cifs/smb2ops.c
> > +++ b/fs/cifs/smb2ops.c
> > @@ -3098,8 +3098,8 @@ smb2_query_reparse_tag(const unsigned int xid, struct cifs_tcon *tcon,
> >         rqst[1].rq_nvec = SMB2_IOCTL_IOV_SIZE;
> >
> >         rc = SMB2_ioctl_init(tcon, server,
> > -                            &rqst[1], fid.persistent_fid,
> > -                            fid.volatile_fid, FSCTL_GET_REPARSE_POINT,
> > +                            &rqst[1], COMPOUND_FID,
> > +                            COMPOUND_FID, FSCTL_GET_REPARSE_POINT,
> >                              true /* is_fctl */, NULL, 0,
> >                              CIFSMaxBufSize -
> >                              MAX_SMB2_CREATE_RESPONSE_SIZE -
> > --
> > 2.17.1
> >



-- 
Thanks,

Steve



[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux