Re: [PATCH][SMB3.1.1] do not fail if no encryption required when server doesn't support encryption

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/17/2020 5:03 AM, Steve French wrote:
     There are cases where the server can return a cipher type of 0 and
     it not be an error. For example, if server only supported AES256_CCM
     (very unlikely) or server supported no encryption types or

It seems me that the simpler statement is that there are
no ciphers supported in common between client and server.

     had all disabled. In those cases encryption would not be supported,
     but that can be ok if the client did not require encryption on mount.

     In the case in which mount requested encryption ("seal" on mount)

I'm confused. Doesn't "seal" mean signing?

Tom.

     then checks later on during tree connection will return the proper
     rc, but if seal was not requested by client, since server is allowed
     to return 0 to indicate no supported cipher, we should not fail mount.

     Reported-by: Pavel Shilovsky <pshilov@xxxxxxxxxxxxx>
     Signed-off-by: Steve French <stfrench@xxxxxxxxxxxxx>





[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux