Shyam Prasad N <nspmangalore@xxxxxxxxx> writes: > Attaching the patch with the review comments incorporated. > Tested a few positive and negative test cases. Works as expected. Great, I only have one small comment: > + reinit_parsed_info = > + (struct parsed_mount_info *) malloc(sizeof(*reinit_parsed_info)); Don't cast malloc return value (void* gets implicitely promoted to any pointer type). Cheers, -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
