Hi, I was going through the code path in cifs.ko where we get the credentials of an user using request_key mechanism. And I think there may be an issue in both ntlmssp and krb5 case. 1. For ntlmssp, I see that the credentials are stored in the keyring with IPv4 or IPv6 address as the key. Suppose the mount was initially done using hostname, and IP address changes (more likely in Azure scenario), we may end up looking for credentials with the wrong key. 2. For ntlmssp, if I add another user credentials to the keyring using cifscreds, doesn’t that overwrite the prev user’s credentials? Or is there a way to store multiple credentials for the same server? 3. For krb5, and multiuser mount, how should cifs.ko get the username for a user? Currently, I don’t think we read the username from anywhere. -- -Shyam
