Shyam Prasad N <nspmangalore@xxxxxxxxx> writes: > These changes look good to me. > However, I see other places in the code where these flags are checked > separately. Don't we want to replace all those with is_tcon_dfs() > calls? Yes, probably. We could do that in separate patches, however it would require a lot of testing. I initially did it for dfs mount because it was easily reproducible when running smb1 tests against Windows 2019. Thanks for pointing that out. I can take a look at it when time allows.