Hi, ----- Original Message ----- > From: "Steve French" <smfrench@xxxxxxxxx> > To: "Xiaoli Feng" <xifeng@xxxxxxxxxx> > Cc: "CIFS" <linux-cifs@xxxxxxxxxxxxxxx> > Sent: Wednesday, August 5, 2020 1:39:43 AM > Subject: Re: fallocate can't change the cifs disk space usage > > I was looking in a little more detail at tests 213 and 228 ... and I > see 228 passing to all servers I tried. Did you see a problem with > that? Sorry, I made a mistake. I tested 228 in RHEL8 before. It's failed. Maybe it needs some patches. Now I re-test 228 in 5.8.0-rc7+. It's passed for both servers. And 213 is also passed if "strict allocate = yes" is set. And now I met another issue for windows file server. client is 5.8.0-rc7+. # truncate -s 320k windows/file # fallocate -o 2k -l 256k windows/file fallocate: fallocate failed: Operation not supported # fallocate -o 320k -l 256k windows/file # Seems the offset for fallocate need beyond the size of truncate. But for xfs, it's passed. This test is base on test 255. > > With 213 I see it working to Windows, and to Samba test 213 also works > but only if "strict allocate = yes" is set in smb.conf (I just > verified it on the buildbot) > > > On Sun, Aug 2, 2020 at 9:55 PM Xiaoli Feng <xifeng@xxxxxxxxxx> wrote: > > > > Hello all, > > > > Recently when I'm investigating the xfstests generic/213 generic/228 > > failures for cifs. > > Found that fallocate can't change the cifs disk space usage. Comparing xfs > > fileystem, > > fallocate can update space usage. > > > > My tests is in 5.8.0-rc7+. I also file a bug for this issue. > > https://bugzilla.kernel.org/show_bug.cgi?id=208775 > > > > # cat /etc/samba/smb.conf > > [cifs] > > path=/mnt/cifs > > writeable=yes > > # mount //localhost/cifs cifs -o > > user=root,password=redhat,cache=none,actimeo=0 > > # df -h cifs > > Filesystem Size Used Avail Use% Mounted on > > //localhost/cifs 36G 23G 13G 66% /root/cifs > > # fallocate -o 0 -l 2g /root/cifs/file1 > > # df -h cifs > > Filesystem Size Used Avail Use% Mounted on > > //localhost/cifs 36G 23G 13G 66% /root/cifs > > ]# ls -l cifs > > total 1 > > -rwxr-xr-x. 1 root root 2147483648 Aug 2 21:57 file1 > > > > Thanks. > > > > -- > > Best regards! > > XiaoLi Feng 冯小丽 > > > > > -- > Thanks, > > Steve > >