patch updated - and merged into cifs-2.6.git for-next pending additional review On Tue, Jul 14, 2020 at 8:30 PM kernel test robot <lkp@xxxxxxxxx> wrote: > > Hi Ronnie, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on cifs/for-next] > [also build test WARNING on v5.8-rc5 next-20200714] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Ronnie-Sahlberg/cifs-smb1-Try-failing-back-to-SetFileInfo-if-SetPathInfo-fails/20200715-061927 > base: git://git.samba.org/sfrench/cifs-2.6.git for-next > config: arm64-randconfig-r005-20200714 (attached as .config) > compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 02946de3802d3bc65bc9f2eb9b8d4969b5a7add8) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install arm64 cross compiling tool for clang build > # apt-get install binutils-aarch64-linux-gnu > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > All warnings (new ones prefixed by >>): > > >> fs/cifs/cifssmb.c:5917:1: warning: no previous prototype for function 'CIFSSMBSetPathInfoFB' [-Wmissing-prototypes] > CIFSSMBSetPathInfoFB(const unsigned int xid, struct cifs_tcon *tcon, > ^ > fs/cifs/cifssmb.c:5916:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > int > ^ > static > 1 warning generated. > -- > In file included from fs/cifs/cifssmb.c:40: > In file included from fs/cifs/cifsglob.h:32: > fs/cifs/smb2pdu.h:28:10: error: 'cifsacl.h' file not found with <angled> include; use "quotes" instead > #include <cifsacl.h> > ^~~~~~~~~~~ > "cifsacl.h" > >> fs/cifs/cifssmb.c:5917:1: warning: no previous prototype for function 'CIFSSMBSetPathInfoFB' [-Wmissing-prototypes] > CIFSSMBSetPathInfoFB(const unsigned int xid, struct cifs_tcon *tcon, > ^ > fs/cifs/cifssmb.c:5916:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > int > ^ > static > 1 warning and 1 error generated. > > vim +/CIFSSMBSetPathInfoFB +5917 fs/cifs/cifssmb.c > > 5915 > 5916 int > > 5917 CIFSSMBSetPathInfoFB(const unsigned int xid, struct cifs_tcon *tcon, > 5918 const char *fileName, const FILE_BASIC_INFO *data, > 5919 const struct nls_table *nls_codepage, > 5920 struct cifs_sb_info *cifs_sb) > 5921 { > 5922 int oplock = 0; > 5923 struct cifs_open_parms oparms; > 5924 struct cifs_fid fid; > 5925 int rc; > 5926 > 5927 oparms.tcon = tcon; > 5928 oparms.cifs_sb = cifs_sb; > 5929 oparms.desired_access = GENERIC_WRITE; > 5930 oparms.create_options = cifs_create_options(cifs_sb, 0); > 5931 oparms.disposition = FILE_OPEN; > 5932 oparms.path = fileName; > 5933 oparms.fid = &fid; > 5934 oparms.reconnect = false; > 5935 > 5936 rc = CIFS_open(xid, &oparms, &oplock, NULL); > 5937 if (rc) > 5938 goto out; > 5939 > 5940 rc = CIFSSMBSetFileInfo(xid, tcon, data, fid.netfid, current->tgid); > 5941 CIFSSMBClose(xid, tcon, fid.netfid); > 5942 out: > 5943 > 5944 return rc; > 5945 } > 5946 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx -- Thanks, Steve
